Grant Shoshin Shangreaux <[email protected]> writes: > Yoni Rabkin writes: > >> I added emms-tag-tracktag to emms-all, and fixed the copyright notice on >> the file in the opus-tags branch. > > thanks for fixing that :) > >> If there isn't anything else you want to add or modify for now, please >> merge the opus-tags branch into the main git repo. > > There's more I'd like to do, but not directly related to being able to > use tracktag. The one thing I'd consider adding is to remove the genre > field for opus files, since by default it is using tracktag that can't > write it. I'd like to figure out a better way, since a user might want > to use tracktag for more than just opus. However, that feels like a > bigger project. > > I would add > > ("opus" . ,(emms-tag-editor-make-format (remove 'info-genre tags))) > > to the emms-tag-editor-formats variable to handle this.
That's fine. > I notice ogg and flac remove info-year, though that seems to be because > the minimal specification for Vorbis comment headers do not include a > year field, but only date. Perhaps I should remove year from "opus" as > well? > > I think there's further discussion on what tags could be added, it feels > like the minimal set should be good for now. > > What do you think? A minimal set, so to speak, is good. > Also, if you had a different suggestion for the circular dependency, I'd > love to hear it. I'm picking up Elisp skills as I go along, but EMMS is > a larger package than any other I've worked on. The solution you have right now is fine. The priority is to get this into people's hands and have them test it. -- "Cut your own wood and it will warm you twice"
