Mike Kazantsev <[email protected]> writes: > Hi, > > Mostly I've only been using emms to play very common mp3/ogg files, or > occasionally internet-radio streams, but recently downloaded a pack of > keygen music files in tracker/sequencer midi-ish formats, and of > course it (and its ffmpeg base) handles those just fine as well. > > I've added those to 'regex in emms-player-mpv in my config like this: > > (emms-player-set emms-player-mpv 'regex (apply > #'emms-player-simple-regexp (append emms-player-base-format-list > '("xm" "mod" "it" "mid" "v2m" "ym" "s3m" "sid" "ahx" "fc13" "fc14" > "sap" "rad" "hsc" "sc68" "d00" "amd" "bp" "spc" "nsf" "mtm" > "mo3")))) > > Normally, I'd think expanding that parameter in upstream emms might be > a good idea too, as why not make it work for someone else > out-of-the-box as well... > > But given rather large degree of obscurity and variety of these old > file formats nowadays, I think there's high chance that simply no one > else uses them anymore, and adding so many weird extensions seems like > a good way to bump into them matching random other non-media files > too, unnecessarily. > > So wanted to ask if maybe anyone else added (some of) those to local > 'regex config as well, or maybe knows of other good reason to add them > there regardless? > > If not, I think it's probably best to leave such one-off obscure > use-case to individual tweaks, and stick with common formats in > defaults.
I think that adding these shouldn't be an issue. If someone points Emms at a directory with a bunch of files then they should expect that Emms will try to read the files therein. However, it would be nice if the code had a comment explaining what those files are to people who are looking at it and wondering what, for instance, a "d00" file could possibly be. -- "Cut your own wood and it will warm you twice"
