So I'm not super-familiar with exactly how emscripten uses LLVM's LTO
feature, but LTO is definitely a use case that is supported by upstream, as
long as we use it in a way similar to what they expect. PNaCl always uses
LTO (when optimizations are enabled) and the  issues we've had with it
(which have been minor) have mostly just stemmed from those divergences
(e.g. including libc in the optimization, which LLVM's LTO doesn't do by
default).

On Tue, Apr 18, 2017 at 10:39 AM Alon Zakai <alonza...@gmail.com> wrote:

> About the runtime exception, it would be good to get a testcase showing
> it, that is very serious.
>
> About switching binaryen, yes, just changing the folder should be fine.
> Just make sure it's the right folder, the one pointed to by BINARYEN_ROOT
> in .emscripten. Builds are deterministic, so if you see the output change
> when you change the folder, it's ok.
>
> About llvm-lto, we should talk to upstream LLVM. If they recommend
> enabling it, and if they have it fully tested (i.e., tested as much as the
> non-lto mode), then we should consider it.
>
>
> On Tue, Apr 18, 2017 at 3:39 AM, Gaurav Dewan <gauravdewan...@gmail.com>
> wrote:
>
>> Now that it appears llvm-lto helps a lot with size reduction with latest
>> clang(this was not the case earlier), does it make sense to include in
>> regression test suite and make it on by default on Oz build ?
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "emscripten-discuss" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to emscripten-discuss+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "emscripten-discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to emscripten-discuss+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"emscripten-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to emscripten-discuss+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to