Figured it out -- my code had been setting Module.mainScriptUrlOrBlob
without the relative path set, which somehow didn't cause any problems
before :D but definitely caused loading the wrong URL (without
subdirectory) with 3.1.58 when launching a worker.

(Possibly this was due to loading the _worker thread helper js_ with the
right URL and then passing it the _local path to the main file_ which,
relative to the worker, was in the same directory so a bare path was fine.
If you weren't fiddling with this setting to host things in a subdirectory
before, you probably won't have trouble.)

After setting this correctly to include the relative path, it seems happier
and I have a functioning VP9 codec in pthread build too. :D

Huzzah!

-- brooke

On Thu, Apr 25, 2024 at 9:06 AM Brooke Vibber <br...@pobox.com> wrote:

> I had a problem updating my ogv.js codec shims to use 3.1.58 with the new
> pthreads output, I'll try tracking down exactly what was going wrong but it
> seems like the path to the main .js wasn't getted transmitted correctly
> through to the worker loader and it would just 404 out with a bad path.
>
> Once I get a chance to test in more detail it's probably something
> sensible, but it didn't work as just a drop-in upgrade vs 3.1.57.
>
> -- brooke
>
> On Tue, Apr 16, 2024 at 12:36 PM 'Sam Clegg' via emscripten-discuss <
> emscripten-discuss@googlegroups.com> wrote:
>
>> ;TLDR; If you build/deploy pthread-based programs you no longer need to
>> worry about that extra `.worker.js` file.
>>
>> I'm hoping to land this change today which is fairly large internal
>> change to the pthread workers are bootstapped:
>> https://github.com/emscripten-core/emscripten/pull/21701
>>
>> The main externally visible change is that emscripten will no longer
>> depend on a separate `.worker.js` file to start the pthread workers.
>>
>> This means that build and deployment system will need to be updated to
>> account for the lack of this file.  It's one less file to deal with so it
>> should be a simplification in all cases.   For a tran sition period (I
>> imagine a few releases) emscripten will continue to generate an empty
>> `.worker.js` (unless you build with `-sSTRICT`) to give folks some time to
>> transition away from deploying the `.worker.js` file.
>>
>> cheers,
>> sam
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "emscripten-discuss" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to emscripten-discuss+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/emscripten-discuss/CAL_va2_jh9eYSYfJz8NDQhjOvTf4wjku1YO6K1Du6fusAnVgGA%40mail.gmail.com
>> <https://groups.google.com/d/msgid/emscripten-discuss/CAL_va2_jh9eYSYfJz8NDQhjOvTf4wjku1YO6K1Du6fusAnVgGA%40mail.gmail.com?utm_medium=email&utm_source=footer>
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"emscripten-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to emscripten-discuss+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/emscripten-discuss/CAFnWYTn2g8ESKw1RiDpeTfaHntTOe9U_%3DEaDymYHaoKEUOoKrg%40mail.gmail.com.

Reply via email to