On Mon, Jul 09, 2007 at 11:30:01PM +0200, Hannes Tschofenig wrote:
> http://www.tschofenig.com/svn/draft-clancy-emu-eap-gpsk/draft-ietf-emu-eap-gpsk-06.txt
> * fixed the description of flexibility in the introduction section
> * added terms to the terminology section
> * minor update to the key derivation section
> * clarified the vendor-specific ciphersuite usage
> * modified the length of the CSuite/Vendor and CSuite/Specifier format
> * added reference to AES
> * fixed minor bugs in the examples
> * updated IANA Considerations section
Looks good. Couple of editorial comments about missed edits for
PData/Vendor,Specifier size change:
7.4. Protected Data
"Type values are encoded as a 6-octet string and represented by a
4-octet vendor and 2-octet specifier field. The vendor field
indicates the type as either standards-specified or vendor-specific.
If these three octets are 0x00000000, then the value is standards-"
s/these three octets/these four octets/
0 1 2 3
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| PData/Vendor | ...
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
PData/Specifier | PData/Length |
should be replaced with
0 1 2 3
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| PData/Vendor |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| PData/Specifier | PData/Length |
"For PData/Vendor field 0x000000, the following PData/Specifier fields
are defined:"
s/0x000000/0x00000000/
11. IANA Considerations
"The following is the initial protected data PData/Specifier registry
setup:
o 0x000000 : Reserved
o 0x000001 : Protected Results Indication
The PData/Specifier field is 24 bits long and all other values are
available via IANA registration."
s/0x000000/0x0000/
s/0x000001/0x0001/
s/24 bits/16 bits/
--
Jouni Malinen PGP id EFC895FA
_______________________________________________
Emu mailing list
[email protected]
https://www1.ietf.org/mailman/listinfo/emu
