----- Original Message ----- > From: "Alon Bar-Lev" <alo...@redhat.com> > To: "Allon Mureinik" <amure...@redhat.com> > Cc: engine-devel@ovirt.org > Sent: Wednesday, November 28, 2012 10:14:02 AM > Subject: Re: [Engine-devel] Shipping settings.xml in oVirt engine's git repo > (was RE: maven settings.xml in building > ovirt engine wiki) > > > > ----- Original Message ----- > > From: "Allon Mureinik" <amure...@redhat.com> > > To: engine-devel@ovirt.org > > Sent: Wednesday, November 28, 2012 10:05:18 AM > > Subject: [Engine-devel] Shipping settings.xml in oVirt engine's git > > repo (was RE: maven settings.xml in building > > ovirt engine wiki) > > > > <snipped> > > > Note that settings.xml isn't shifted with ovirt-engine, nor > > > stored > > > on > > > ovirt-engine git repository. Therefore there is no real method to > > > control its content expect updating the wiki page. > > > > Spinning off from the previous discussion - we can't really control > > the contents of settings.xml, but perhaps we can make them easier > > to > > get. > > > > Today, the flow is like this: > > 1. git clone - depends on gerrit.ovirt.org > > 2. wget settings.xml - depends on wiki.ovirt.org > > > > Suppose we ship settings.xml inside the configuration folder of > > ovirt > > (next to engine-code-format.xml and engine-commit-template.txt). > > Then you'll have to do: > > 1. git clone - depends on gerrit.ovirt.org > > 2. cp $OVIRT_GIT/config/settings.xml ~/.m2/ > > > > This may a bit simpler, and at the very least, when we update our > > code (e.g., to assume java7, *hint*), we can make all the changes > > in > > a single commit, and not have to update the code and then upload a > > file to the wiki. > > > > Comments? Feedback? > > First thing... I don't like changing global state of a machine only > because we require some setting... > > So copying <ANYTHING> to ~/.m2 is completely wrong in my opinion. > > There is -gs parameter for maven to specify alternate settings file, > I strongly recommend people use it. > > Also, as far as I understand we only need some attributes defined... > It is simple to use: > > $ export MAVEN_OPTS="-Dwhatever=value -Dwhatever=value" > > Before executing eclipse or make... > > We can also integrate the environment variables idea into the maven > build, instead of using properties use environment variables... then > before executing build we: > > $ export JBOSS_HOME= > $ export OVIRT_JDK_HOME= (optional) > > If anyone prefers/chooses to use settings.xml he can create his > own... > > So there are so many options, the last option is to use settings.xml > in my opinion... not that I against adding this template, but I > first suggest we consider removing its usage completely.... :) > > Regards, > Alon > > > > > > > -Allon
I'll rephrase. /today/ we provide an example of settings.xml in "Building the oVirt Engine" wiki page. People who understand maven will not overwrite their settings.xml with it, and people who don't have a comfortable quick start. I propose to supply this /exmaple/ in a more accessible place $OVIRT_GIT/config. People who didn't overwrite their existing .m2 file still won't, and people who did have an easier way of doing it. _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel