----- Original Message ----- > From: "Omer Frenkel" <ofren...@redhat.com> > To: "Laszlo Hornyak" <lhorn...@redhat.com> > Cc: "engine-devel" <engine-devel@ovirt.org> > Sent: Sunday, March 10, 2013 9:36:46 AM > Subject: Re: [Engine-devel] new engine watchdog version > > > > ----- Original Message ----- > > From: "Laszlo Hornyak" <lhorn...@redhat.com> > > To: "engine-devel" <engine-devel@ovirt.org> > > Sent: Friday, March 8, 2013 7:18:59 PM > > Subject: [Engine-devel] new engine watchdog version > > > > Hi, > > > > I uploaded a new version of the watchdog patch. This patch is still > > a > > work in progress, it adds audit log alerts to the functionality. > > http://gerrit.ovirt.org/12419/ > > > > Feature page: > > http://www.ovirt.org/Features/Watchdog_engine_support > > > > Laszlo > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > Hi, > i looked at the patch and there is something i don't understand, > i see you are treating the watchdog as a vm device, which is great, > so why do we need to save the device details in vm_static table in > addition to the vm_devices? > i think its even not used at all (only setting the device in command > which could be parameters, no need to persist)
Omer, This is WIP, so a few bit are still in the works. Generally speaking model and action are needed since we should be able to use it for template creation, OVF*, and user interaction (user may choose a different model or watchdog for specific VM). Do you recommend on keeping this as spec-param? _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel