----- Original Message ----- > From: "Itamar Heim" <[email protected]> > To: "Daniel Erez" <[email protected]> > Cc: "Einav Cohen" <[email protected]>, "Eldan Hildesheim" <[email protected]>, > "engine-devel" > <[email protected]>, "Eldan Hildesheim" <[email protected]> > Sent: Wednesday, May 29, 2013 3:56:30 PM > Subject: Re: [Engine-devel] static header only in VM dialog? > > On 05/29/2013 08:36 AM, Daniel Erez wrote: > ... > >> relevant/correct to introduce this new concept only in the VM-like > >> dialogs). > >> > >> regarding the specific concern about the DC/Cluster values that aren't > >> necessarily relevant > >> for each side-tab in the dialog: I agree with that statement, however: > >> > >> - putting the "Instance Type" drop-down at the top static section is very > >> useful (see [4] > >> for explanation), and as the Instance Types list is derived from the > >> selected > >> DC, it makes > >> sense (to me) to put the DC in that top static section as well. > >> > >> - the DC/Cluster are relevant for some of the tabs in the dialog (Host, > >> Resource Allocation?) > > > > Only for Host. > > Resource Allocation is directly affected by the selected template. > > Therefore, it sounds very confusing to me... > > Unless we add template to the static header as well? > > (which will be odd for the other tabs). > > isn't resource allocation affected by the vm type (optimized for > server/desktop), rather than the template?
Only Thin vs. Clone is affected by VM type. But, SDs are affected by the selected template. > > (and template is on the static header as well - images are a subset of > templates, but you will see there both images and templates). According to the current patch only DC and Cluster are static in the header. Which means that until we have a full implementation merged the static header would surely be confusing. Afterwards, I'm still not sure how most tabs are influenced, e.g.: Initial Run / Console / Boot Options are really related to the DC/Cluster/Instance Type? > > > > > So I still don't get the motivation UX-wise. > > E.g. it seems really weird to change the entire DC from Console tab > > (or, as a matter of fact, from most other tabs). > > In the new instance type dialog, which tabs could be directly affected by > > DC/Cluster? > > IIUC, only Host? Do we really need a static header just for this tab? > > > >> so for consistency-within-the-dialog considerations, it is probably a good > >> idea to simply > >> always show these fields within this top static section. > >> > >> [there is a good chance that I am missing your point here - please correct > >> me > >> if necessary] > >> > >> [1] http://gerrit.ovirt.org/#/c/14936/ > >> > >> [2] http://www.ovirt.org/Features/Instance_Types > >> > >> [3] http://www.ovirt.org/images/9/9e/Instance_type.pdf > >> > >> [4] whenever changing the "Instance Type" value, you can automatically see > >> how these changes > >> affect the fields in the current tab on which you are standing (e.g. if > >> you > >> are standing on > >> the "System" side-tab, you can change the "Instance Type" selected item > >> and > >> immediately see > >> the changes within the "System" side-tab contents), and vice-versa: if you > >> are changing a value > >> that was originally propagated from the instance-type, you will see the > >> instance-type automatically > >> change to "custom"/"not applicable" as a result, so no need to "jump" > >> between > >> side-tabs in order > >> to observe these changes. > >> > >>> > >>>> > >>>> ---- > >>>> Thanks, > >>>> Einav > >>>> > >>>> [1] http://www.ovirt.org/images/9/9e/Instance_type.pdf > >>>> > >>>> ----- Original Message ----- > >>>>> From: [email protected] > >>>>> To: "Tomas Jelinek" <[email protected]> > >>>>> Cc: "Vojtech Szocs" <[email protected]>, "Einav Cohen" > >>>>> <[email protected]>, > >>>>> "Frank Kobzik" <[email protected]>, > >>>>> "Eldan Hildesheim" <[email protected]> > >>>>> Sent: Tuesday, May 28, 2013 5:05:38 PM > >>>>> Subject: Change in ovirt-engine[master]: userportal,webadmin: redesign > >>>>> of > >>>>> vm related dialogs > >>>>> > >>>>> Daniel Erez has posted comments on this change. > >>>>> > >>>>> Change subject: userportal,webadmin: redesign of vm related dialogs > >>>>> ...................................................................... > >>>>> > >>>>> > >>>>> Patch Set 5: (1 inline comment) > >>>>> > >>>>> Code looks good. > >>>>> A few questions regarding the design: > >>>>> 1. Why do we want the static header only in VM dialog? > >>>>> 2. DC/Host are really relevant for all tabs? > >>>>> 3. Is it just a preparation for the final instance type dialog? > >>>>> 4. If it's indeed merely preparation, shouldn't it be merged only once > >>>>> we > >>>>> have the full picture of the new dialog? > >>>>> > >>>>> .................................................... > >>>>> File > >>>>> frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml > >>>>> Line 21: > >>>>> Line 22: .header { > >>>>> Line 23: background-color: #D3D3D3; > >>>>> Line 24: border-bottom: 1px solid #CED8DF; > >>>>> Line 25: margin-bottom: 15px; > >>>>> is it supposed to be that large? > >>>>> Line 26: padding-top: 6px; > >>>>> Line 27: margin-top: 4px; > >>>>> Line 28: margin-right: 3px; > >>>>> Line 29: display: none; > >>>>> > >>>>> > >>>>> -- > >>>>> To view, visit http://gerrit.ovirt.org/14635 > >>>>> To unsubscribe, visit http://gerrit.ovirt.org/settings > >>>>> > >>>>> Gerrit-MessageType: comment > >>>>> Gerrit-Change-Id: Icad8098e286f821da25fac22fd0a840a42f105c9 > >>>>> Gerrit-PatchSet: 5 > >>>>> Gerrit-Project: ovirt-engine > >>>>> Gerrit-Branch: master > >>>>> Gerrit-Owner: Tomas Jelinek <[email protected]> > >>>>> Gerrit-Reviewer: Daniel Erez <[email protected]> > >>>>> Gerrit-Reviewer: Einav Cohen <[email protected]> > >>>>> Gerrit-Reviewer: Eldan Hildesheim <[email protected]> > >>>>> Gerrit-Reviewer: Frank Kobzik <[email protected]> > >>>>> Gerrit-Reviewer: Tomas Jelinek <[email protected]> > >>>>> Gerrit-Reviewer: Vojtech Szocs <[email protected]> > >>>>> > >>>> > >>> > >> > > _______________________________________________ > > Engine-devel mailing list > > [email protected] > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > _______________________________________________ Engine-devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-devel
