Hi, Thank you reviewers, the patch is now merged.
Just an idea how to avoid (or early detect) these problems in the future: we could set up a junkins job to run the tests with "-DforkMode=always" appended to the mvn command line, so that tests will have an isolated environment. If this build falis, we know that there is a mistake in a test. Hopefully it is only the test :) As forking JVM is relatively costly and time-consuming operation this would run probably once a day, but perform all the same tests as the normal build triggered by gerrit. David, can you help us setting up this configuration? Thank you, Laszlo ----- Original Message ----- > From: "Greg Sheremeta" <gsher...@redhat.com> > To: "Laszlo Hornyak" <lhorn...@redhat.com> > Cc: "Roy Golan" <rgo...@redhat.com>, engine-devel@ovirt.org > Sent: Tuesday, August 27, 2013 4:57:39 PM > Subject: Re: [Engine-devel] NPE in RunVmCommandTest > > Excellent, thanks. Reviewing now. > > Greg > > ----- Original Message ----- > > From: "Laszlo Hornyak" <lhorn...@redhat.com> > > To: "Greg Sheremeta" <gsher...@redhat.com> > > Cc: "Roy Golan" <rgo...@redhat.com>, engine-devel@ovirt.org > > Sent: Tuesday, August 27, 2013 9:45:17 AM > > Subject: Re: [Engine-devel] NPE in RunVmCommandTest > > > > Hi, > > > > I ran into the same, sent a patch, my explanation for the problem is in the > > commit msg: > > http://gerrit.ovirt.org/18608 > > > > Thx, > > Laszlo > > > > ----- Original Message ----- > > > From: "Greg Sheremeta" <gsher...@redhat.com> > > > To: "Roy Golan" <rgo...@redhat.com> > > > Cc: engine-devel@ovirt.org > > > Sent: Wednesday, August 21, 2013 10:07:25 PM > > > Subject: [Engine-devel] NPE in RunVmCommandTest > > > > > > Hi Roy, > > > > > > On a fresh clone of ovirt-engine master, I'm experiencing a very strange > > > test > > > failure in RunVmCommandTest. I believe it's race-condition based. It's > > > related to the osRepository variable that you added to RunVmCommand in > > > ba8ada49. Sometimes it's just null in the 16 of the 17 RunVmCommandTest > > > tests, causing an NPE at RunVmCommand:680. Surefire report attached. I > > > can > > > duplicate it pretty well on my home workstation running a command-line > > > build > > > (which is a little slower than my T520). I can't duplicate it on the T520 > > > running a command-line build. I can duplicate it on the T520 if I run the > > > tests inside Eclipse (right click on a test method, Run As > JUnit test, > > > wait 30 seconds, fail). If there is a race condition, maybe it's related > > > to > > > setting osRepository in the initializer. That's just a guess. > > > > > > Can you assist? > > > > > > Thanks, > > > Greg > > > > > > > > > Greg Sheremeta > > > Red Hat, Inc. > > > Sr. Software Engineer, RHEV > > > Cell: 919-807-1086 > > > gsher...@redhat.com > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel