The problem is creating a p_key with null values. The script will fail on any user that has an event_subscriber record.
bug: https://bugzilla.redhat.com/show_bug.cgi?id=1072866 patch: http://gerrit.ovirt.org/#/c/25372/ will need backport to 3.4! Mooli ----- Original Message ----- > > > ----- Original Message ----- > > From: "Liran Zelkha" <liran.zel...@gmail.com> > > To: "Adam Litke" <ali...@redhat.com> > > Cc: "engine-devel" <engine-devel@ovirt.org> > > Sent: Tuesday, March 4, 2014 3:20:57 PM > > Subject: Re: [Engine-devel] Schema upgrade failure on master > > > > had the same issue. Run from psql: > > truncate table event_subscriber; > > Then run the script. Note that this will delete all the rows from your > > table... > > > Sorry for jumping on that late, but if this occurs when event_subscriber is > not empty then this is a bug since it will fail also in customer site. > In that case I think that you should open a bug and since the notification > mechanism is heavily used , I think this is a blocker > > Can you please open a bug and assign on me > > Thanks > Eli > > > > > > > On Tue, Mar 4, 2014 at 3:18 PM, Adam Litke < ali...@redhat.com > wrote: > > > > > > On 04/03/14 00:10 -0500, Martin Perina wrote: > > > > > > Hi Adam, > > > > I didn't notice any problem with this script. Was the database you tried to > > upgrade empty? > > If not could you please send me contents of your event_subscriber table? > > > > engine=> select * from event_subscriber ; > > subscriber_id | event_up_name | method_id | method_address | tag_name > > ------------------------------ --------+--------------------- > > --------+----------- > > +--------------------------+-- -------- > > fdfc627c-d875-11e0-90f0- 83df133b58cc | VM_SET_TICKET | 0 | > > ali...@brewer.alitke.net | fdfc627c-d875-11e0-90f0- 83df133b58cc | > > VM_DOWN_ERROR | 0 | ali...@brewer.alitke.net | fdfc627c-d875-11e0-90f0- > > 83df133b58cc | VDS_INITIATED_RUN_VM_FAILED | 0 | ali...@brewer.alitke.net | > > (3 rows) > > > > > > > > > > > > Thanks > > > > Martin Perina > > > > ----- Original Message ----- > > > > > > From: "Adam Litke" < ali...@redhat.com > > > To: engine-devel@ovirt.org > > Sent: Monday, March 3, 2014 11:26:28 PM > > Subject: [Engine-devel] Schema upgrade failure on master > > > > Hi, > > > > I've recently rebased to master and it looks like the > > 03_05_0050_event_notification_ methods.sql script is failing on schema > > upgrade. Is this a bug or am I doing something wrong? To upgrade I > > did the normal proceedure with my development installation: > > > > make install-dev ... > > ~/ovirt/bin/engine-setup > > > > Got this result in the log file: > > > > psql:/home/alitke/ovirt-** FILTERED**/share/ovirt-** > > FILTERED**/dbscripts/upgrade/ 03_05_0050_event_notification_ > > methods.sql:10: > > ERROR: column "notification_method" contains null values > > FATAL: Cannot execute sql command: > > --file=/home/alitke/ovirt-** FILTERED**/share/ovirt-** > > FILTERED**/dbscripts/upgrade/ 03_05_0050_event_notification_ methods.sql > > > > 2014-03-03 17:20:34 DEBUG otopi.context context._executeMethod:152 method > > exception > > Traceback (most recent call last): > > File "/usr/lib/python2.7/site- packages/otopi/context.py", line 142, in > > _executeMethod > > method['method']() > > File > > "/home/alitke/ovirt-** FILTERED**/share/ovirt-** FILTERED**/setup/bin/../ > > plugins/ovirt-**FILTERED**- setup/ovirt-**FILTERED**/db/ schema.py", > > line 280, in _misc > > osetupcons.DBEnv.PGPASS_FILE > > File "/usr/lib/python2.7/site- packages/otopi/plugin.py", line 451, in > > execute > > command=args[0], > > RuntimeError: Command > > '/home/alitke/ovirt-** FILTERED**/share/ovirt-** > > FILTERED**/dbscripts/schema. > > sh' > > failed to execute > > > > -- > > Adam Litke > > ______________________________ _________________ > > Engine-devel mailing list > > Engine-devel@ovirt.org > > http://lists.ovirt.org/ mailman/listinfo/engine-devel > > > > > > -- > > Adam Litke > > ______________________________ _________________ > > Engine-devel mailing list > > Engine-devel@ovirt.org > > http://lists.ovirt.org/ mailman/listinfo/engine-devel > > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ > Engine-devel mailing list > Engine-devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel