just saw you've uploaded a new patch, but still no replies to comments in the body of the patch. please handle that ASAP before we do a second review.
Thanks, Gilad. ----- Original Message ----- > From: "Gilad Chaplik" <gchap...@redhat.com> > To: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.l...@hp.com> > Cc: engine-devel@ovirt.org, "Shang-Chun Liang (David Liang, > HPservers-Core-OE-PSC)" <shangchun.li...@hp.com>, "Chegu > Vinod" <chegu_vi...@hp.com> > Sent: Tuesday, April 1, 2014 11:44:05 AM > Subject: Re: [Engine-devel] Numa feature entities patch > > not yet it's on my TODO list :) we are still at the first patch... > > Thanks, > Gilad. > > > ----- Original Message ----- > > From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.l...@hp.com> > > To: "Gilad Chaplik" <gchap...@redhat.com>, "Shang-Chun Liang (David Liang, > > HPservers-Core-OE-PSC)" > > <shangchun.li...@hp.com> > > Cc: "Doron Fediuck" <dfedi...@redhat.com>, "Chegu Vinod" > > <chegu_vi...@hp.com>, "Martin Sivak" <msi...@redhat.com>, > > "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei....@hp.com>, > > engine-devel@ovirt.org, "Roy Golan" > > <rgo...@redhat.com> > > Sent: Tuesday, April 1, 2014 11:30:46 AM > > Subject: RE: Numa feature entities patch > > > > Hi Gilad, > > > > Did you see updated wiki page design with VdcQueryType, VdcActionType ? > > > > Feel free to let us know if you have any comment. > > > > Best Regards, > > Jason Liao > > > > -----Original Message----- > > From: Gilad Chaplik [mailto:gchap...@redhat.com] > > Sent: 2014年4月1日 15:51 > > To: Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC) > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, > > Chegu; Martin Sivak; Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); > > engine-devel@ovirt.org; Roy Golan > > Subject: Re: Numa feature entities patch > > > > Great to hear :-) > > > > VdcQueryType and VdcActionType with parameters are not part of the initial > > BE > > patch; should part of the server's queries and commands patch. > > > > > > > > Thanks, > > Gilad. > > > > > > ----- Original Message ----- > > > From: "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)" > > > <shangchun.li...@hp.com> > > > To: "Gilad Chaplik" <gchap...@redhat.com>, "Chuan Liao (Jason Liao, > > > HPservers-Core-OE-PSC)" <chuan.l...@hp.com> > > > Cc: "Doron Fediuck" <dfedi...@redhat.com>, "Chegu Vinod" > > > <chegu_vi...@hp.com>, "Martin Sivak" <msi...@redhat.com>, > > > "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei....@hp.com>, > > > engine-devel@ovirt.org, "Roy Golan" > > > <rgo...@redhat.com> > > > Sent: Tuesday, April 1, 2014 3:38:20 AM > > > Subject: RE: Numa feature entities patch > > > > > > Hi Gilad, > > > The below are our understanding. Please correct me if anything wrong. :) > > > For VdcQueryType and VdcActionType with parameters, we think it's need to > > > update in doc asap because the code of this part has not started yet. > > > For other parts that started the coding, We will reach an agreement in > > > gerrit/review and then update in the docs accordingly. > > > > > > Best Regards, > > > David Liang > > > > > > -----Original Message----- > > > From: Gilad Chaplik [mailto:gchap...@redhat.com] > > > Sent: Tuesday, April 01, 2014 1:05 AM > > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC) > > > Cc: Doron Fediuck; Vinod, Chegu; Martin Sivak; Shi, Xiao-Lei (Bruce, HP > > > Servers-PSC-CQ); Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); > > > engine-devel@ovirt.org; Roy Golan > > > Subject: Re: Numa feature entities patch > > > > > > Hi Jason, > > > > > > Please reply on the comments in the patch. > > > Once the code is written I think it's better not to context switch back > > > to > > > the design. > > > we will reach an agreement in gerrit/review and then update the design > > > respectively. > > > > > > > > > Thanks, > > > Gilad. > > > > > > ----- Original Message ----- > > > > From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" > > > > <chuan.l...@hp.com> > > > > To: "Gilad Chaplik" <gchap...@redhat.com> > > > > Cc: "Doron Fediuck" <dfedi...@redhat.com>, "Chegu Vinod" > > > > <chegu_vi...@hp.com>, "Martin Sivak" <msi...@redhat.com>, "Xiao-Lei > > > > Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei....@hp.com>, "Shang-Chun > > > > Liang (David Liang, HPservers-Core-OE-PSC)" <shangchun.li...@hp.com>, > > > > engine-devel@ovirt.org > > > > Sent: Monday, March 31, 2014 7:48:28 PM > > > > Subject: RE: Numa feature entities patch > > > > > > > > Hi Gilad, > > > > > > > > I have update the wiki page design of BE patch 1. add VdcQueryType and > > > > VdcActionType with parameters. > > > > 2. merge some of your comments and Eli's feedback. > > > > > > > > Please take a look at the section > > > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA#Interface > > > > _and_data_structure_in_engine_core > > > > > > > > We appreciate any of the comments from community, and sorry for the > > > > nag. > > > > > > > > Best Regards, > > > > Jason Liao > > > > > > > > -----Original Message----- > > > > From: Gilad Chaplik [mailto:gchap...@redhat.com] > > > > Sent: 2014年3月30日 22:43 > > > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Shi, Xiao-Lei > > > > (Bruce, HP Servers-PSC-CQ); Liang, Shang-Chun (David Liang, > > > > HPservers-Core-OE-PSC) > > > > Cc: Doron Fediuck; Vinod, Chegu; Martin Sivak > > > > Subject: Numa feature entities patch > > > > > > > > Hi all, > > > > > > > > I had some comments :-) IMO this patch [1] has maximum priority. > > > > let's try to merge it ASAP, I will be very responsive to every new > > > > upload. > > > > > > > > Thanks, > > > > Gilad. > > > > > > > > [1] http://gerrit.ovirt.org/#/c/23702/ > > > > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
