On 3/31/2014 7:13 PM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
Assemble the related discussions in this mail session.

Hi Vinod,
On 3/31/2014 2:38 AM, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
We put host level NUMA fields in vds_dynamic because these information are from 
host itself, and NUMA topology may be changed if the host's hardware make a 
change.
Can you please elaborate ? Are you thinking about resource (cpu and/or
memory) hot plug on the host ?
[Bruce] It's not about resource hot plug. In ovirt engine, there is a scheduled 
task which will refresh hosts' and vms' information periodically. Only the 
dynamic and statistics data will be updated during the refresh. So I think the 
resource information, such as cpu and/or memory, should be in dynamic and 
statistics. And in my understanding, the information in dynamic class is the 
changeable information but with a low varying frequency, like cpu topology, 
libvirt/kernel versions, etc.

Hmm...just to be clear.

If one were to exclude resource hot-plug scenarios on the Host...then I would consider the following to be static and not dynamic :

- # of NUMA nodes,
- # of CPUs in each of the NUMA node
- Amount of "installed" memory in each of the NUMA node
- The NUMA node distances.

I don't know enough about oVirt features of being able to keep track of (or) orchestrating host level resource hot plug..but If resource hot plug is to be included in the mix then... # of CPUs in a NUMA node and the amount of memory in a given NUMA node could change... (i.e. some CPUs or some sections of memory ranges could be offlined or onlined using hot plug features on the host).

I can see the libvirt, qemu versions etc. changing (with less frequency based on user updates etc.)..but for host kernel versions to actually change one would most likely require a reboot of the host at which point I would guess that all of the rebooted host information would have to be synch'd up as part of handshakes between VDSM and oVirt engine.

The information in statistics class is the information with a high varying 
frequency, like the usage of cpu/memory, etc. In my opinion, it's reasonable to 
put host level NUMA information in vds_dynamic and host level NUMA statistics 
information in vds_statistics.

Got that part...

Thanks
Vinod

Hi Gilad/Roy/Omer,
I don't know if my understanding is correct. But according to this guess, I 
think it's also reasonable to put vm cpuPin information in vm_static. Because 
cpuPin is user configured information, it will not vary automatically. So we 
don’t need to refresh this information periodically. Please correct me if there 
are any mistakes.

Hi Eli,
Sorry for the nag. If my understanding above is correct, I think we should 
still put host level NUMA fields in vds_dynamic/vds_statistics and vm level 
NUMA fields in vm_static. Since vm level NUMA fields are configured by user and 
they will not vary automatically.


Thanks & Best Regards
Shi, Xiao-Lei (Bruce)

Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei....@hp.com


-----Original Message-----
From: Gilad Chaplik [mailto:gchap...@redhat.com]
Sent: Monday, March 31, 2014 9:31 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel
Cc: Eli Mesika; Roy Golan; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); 
Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun (David Liang, 
HPservers-Core-OE-PSC); Yaniv Dary; engine-devel@ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA 
feature on ovirt

adding Roy & Omer.

why CPU topology is in dynamic?

Thanks,
Gilad.

----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei....@hp.com>
To: "Eli Mesika" <emes...@redhat.com>
Cc: "Gilad Chaplik" <gchap...@redhat.com>, "Roy Golan"
<rgo...@redhat.com>, "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.l...@hp.com>, "Doron 
Fediuck" <dfedi...@redhat.com>, "Chegu Vinod"
<chegu_vi...@hp.com>, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)" 
<shangchun.li...@hp.com>, "Yaniv Dary"
<yd...@redhat.com>, engine-devel@ovirt.org
Sent: Monday, March 31, 2014 3:20:33 PM
Subject: RE: Please help us to review our database schema design with
NUMA feature on ovirt

Thanks Eli.
I will move the vm level NUMA fields to vm_dynamic, and the related
database schema will be updated accordingly.

Thanks & Best Regards
Shi, Xiao-Lei (Bruce)

Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China Telephone +86 23 65683093
Mobile +86 18696583447 Email xiao-lei....@hp.com

-----Original Message-----
From: Eli Mesika [mailto:emes...@redhat.com]
Sent: Monday, March 31, 2014 5:49 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
(David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
engine-devel@ovirt.org
Subject: Re: Please help us to review our database schema design with
NUMA feature on ovirt



----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei....@hp.com>
To: "Gilad Chaplik" <gchap...@redhat.com>, "Eli Mesika"
<emes...@redhat.com>, "Roy Golan" <rgo...@redhat.com>
Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.l...@hp.com>, "Doron Fediuck" <dfedi...@redhat.com>, "Chegu Vinod"
<chegu_vi...@hp.com>, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
<shangchun.li...@hp.com>, "Yaniv Dary" <yd...@redhat.com>,
engine-devel@ovirt.org
Sent: Monday, March 31, 2014 12:38:04 PM
Subject: RE: Please help us to review our database schema design
with NUMA feature on ovirt

We put host level NUMA fields in vds_dynamic because these
information are from host itself, and NUMA topology may be changed
if the host's hardware make a change. NUMA information are similar
to the host's cpu topology information like cpu_cores and
cpu_sockets which are in vds_dynamic, we refer to this.
VM level NUMA fields are configured by user, and actually we
originally think they should be in vm_dynamic. But we found that the
field of another feature cpuPin which is similar as NUMA feature is
in vm_static, so we put vm NUMA fields in vm_static.
Do you think we need to put VM level NUMA fields in vm_dynamic?
I think that in this case we should fix cpuPin to be in vm_dynamic and
put after that the other NUMA fields in vm_dynamic as well

Thanks & Best Regards
Shi, Xiao-Lei (Bruce)

Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China Telephone +86 23 65683093
Mobile +86 18696583447 Email xiao-lei....@hp.com


-----Original Message-----
From: Gilad Chaplik [mailto:gchap...@redhat.com]
Sent: Monday, March 31, 2014 5:22 PM
To: Eli Mesika; Roy Golan
Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason
Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang,
Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
engine-devel@ovirt.org
Subject: Re: Please help us to review our database schema design
with NUMA feature on ovirt

+1

IMO: vds data should reside in static VM need to think about it.

Roy?

Thanks,
Gilad.


----- Original Message -----
From: "Eli Mesika" <emes...@redhat.com>
To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei....@hp.com>
Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.l...@hp.com>, "Doron Fediuck" <dfedi...@redhat.com>, "Gilad
Chaplik" <gchap...@redhat.com>, "Chegu Vinod"
<chegu_vi...@hp.com>,
"Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.li...@hp.com>, "Yaniv Dary"
<yd...@redhat.com>, engine-devel@ovirt.org
Sent: Monday, March 31, 2014 12:12:50 PM
Subject: Re: Please help us to review our database schema design
with NUMA feature on ovirt



----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei....@hp.com>
To: "Eli Mesika" <emes...@redhat.com>
Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.l...@hp.com>,
"Doron Fediuck" <dfedi...@redhat.com>, "Gilad Chaplik"
<gchap...@redhat.com>, "Chegu Vinod"
<chegu_vi...@hp.com>,
"Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.li...@hp.com>, "Yaniv Dary"
<yd...@redhat.com>, engine-devel@ovirt.org
Sent: Monday, March 31, 2014 8:56:20 AM
Subject: RE: Please help us to review our database schema design
with NUMA feature on ovirt

Include the devel group.
Thanks Eli for the quick responses for our first design and
sorry for the nag.
We appreciate any of the comments for our database design and
will follow the design to do the implementation if no more
comments.
  http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
Seems OK for me except an unanswered question I had asked in my
first review
:

Why in the Host level NUMA fields are added to vds_dynamic while
in the VM level it is added to vm_static ???
I would expect it to be in both on static or dynamic , can you
please explain ? Thanks

Thanks & Best Regards
Shi, Xiao-Lei (Bruce)

Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China Telephone +86 23
65683093 Mobile +86 18696583447 Email xiao-lei....@hp.com

-----Original Message-----
From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Sent: Friday, March 28, 2014 1:30 PM
To: 'Eli Mesika'
Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun (David
Liang, HPservers-Core-OE-PSC); Yaniv Dary
Subject: RE: Please help us to review our database schema design
with NUMA feature on ovirt

Hi Eli,

After the UX design meeting, we did some modification for the
database schema, and merged some update according to your last review comments.
Now the document has been posted on ovirt wikipage, could you
help to review the database design again:
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA


Thanks & Best Regards
Shi, Xiao-Lei (Bruce)

Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China Telephone +86 23
65683093 Mobile
+86
18696583447 Email xiao-lei....@hp.com


-----Original Message-----
From: Eli Mesika [mailto:emes...@redhat.com]
Sent: Monday, March 24, 2014 6:24 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron
Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun (David
Liang, HPservers-Core-OE-PSC); Yaniv Dary
Subject: Re: Please help us to review our database schema design
with NUMA feature on ovirt



----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei....@hp.com>
To: "Eli Mesika" <emes...@redhat.com>, "Chuan Liao (Jason
Liao, HPservers-Core-OE-PSC)" <chuan.l...@hp.com>
Cc: "Doron Fediuck" <dfedi...@redhat.com>, "Gilad Chaplik"
<gchap...@redhat.com>, "Chegu Vinod" <chegu_vi...@hp.com>,
"Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.li...@hp.com>
Sent: Monday, March 24, 2014 11:23:39 AM
Subject: RE: Please help us to review our database schema
design with NUMA feature on ovirt

Hi Eli,

Thanks for your comments.
I have updated the document according to your comments except
the below
one:
Missing from here are 2 issues:

1) Impact on the search engine, which new columns are
search-able and which changes are planned in the search engine
code to enable that

2) Impact on engine-reports, are those changed planned to be
exposed to the engine data warehouse and required new/modified reports?

Could you tell us more detailed information about the modules
you mentioned above? I mean "search engine" and
"engine-reports". I think we missed these two parts in our previous 
investigation.
I just find org.ovirt.engine.core.bll.SearchQuery, is that the
right object for search engine?
Yes, actually when you are opening the admin UI, there are TABs
for each entity , i.e. Data Center, Cluster, Host etc.
In each, you can see a text-box in which you can search for by
writing a search expression My question is
    1) What is the impact of your work on the search on the Fost and VM
    TABs
       a) Are there any fields that are supported now in the search
       expression
       and should pop-up when you write the expression by the
       auto-completion
       mechanism ?
       b) Are there any added columns displayed in the result of such a
       search
       in the grid ?

How about the engine-reports, could you give us some hints,
like the code location and any more detailed information that
we can start more investigation?
CCing Yaniv D who is in charge of the reports/dwh module Yaniv,
any planned work for adding Numa features to Host/VM in the
reports side ?

Thanks

Thanks & Best Regards
Shi, Xiao-Lei (Bruce)

Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China Telephone +86 23
65683093 Mobile +86 18696583447 Email xiao-lei....@hp.com

-----Original Message-----
From: Eli Mesika [mailto:emes...@redhat.com]
Sent: Sunday, March 23, 2014 4:44 PM
To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang,
Shang-Chun (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei
(Bruce, HP
Servers-PSC-CQ)
Subject: Re: Please help us to review our database schema
design with NUMA feature on ovirt



----- Original Message -----
From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
<chuan.l...@hp.com>
To: emes...@redhat.com
Cc: "Doron Fediuck" <dfedi...@redhat.com>, "Gilad Chaplik"
<gchap...@redhat.com>, "Chegu Vinod" <chegu_vi...@hp.com>,
"Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.li...@hp.com>, "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei....@hp.com>
Sent: Friday, March 21, 2014 10:42:33 AM
Subject: Please help us to review our database schema design
with NUMA feature on ovirt

Hi Eli,

Please help us to review our database schema design with
NUMA feature on ovirt
https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWA
cyQo_IST
Y8
ykDr0I6VY/edit?usp=sharing

Feel free to take comments on document at anywhere
Done, had commented on the document.
Eli

Especially, 5.4 The used interface between engine core and
database(schema)

Your approve and your comments with this section will be
much more appreciate for us.

Best Regards,
Jason Liao



_______________________________________________
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel

Reply via email to