On Tue, Aug 21, 2007 at 02:01:36PM +0100, James Adam wrote: > Hi Peter - > > This looks like a very reasonable patch. The only thing I might ask is > that we think of a better name than "file_types", as > "Engines.file_types" doesn't really nail which its values are being > used for.
Agreed, this name was just something I came up with quickly to test if this approach would work. It should be more descriptive. > My first thought was "Engines.file_types_to_mix", although > I'm definitely open to suggestions. > > If you submit this as a patch to http://dev.rails-engines.org, it will > get committed in the very near future. I did, and I added a couple of suggestions for a more descriptive name to the ticket. Let's continue discussion there, if needed. Regards, Peter Bex Solide ICT - http://www.solide-ict.nl _______________________________________________ Engine-Developers mailing list [email protected] http://lists.rails-engines.org/listinfo.cgi/engine-developers-rails-engines.org
