Sven, have you tackled the javascript and css file aggregation/caching
stuff?
eg: javascript_include_tag(:all, :cache => true) (from DHH's 2.0
release blurb)
That's one of the most exciting features of 2.0 for me, as virtually
every engine I've written has one (or more!) .js files. I didn't see
any code (or tests) looking at that feature yet. But I'm not much of an
engines core hacker yet... :-)
Again, thanks for the work on this!
-Rob
Sven Fuchs wrote:
Hi Tony,
yes, this thread has been continued on the engine-developers list (you
might want to register there, if you are not, and have a glance the
archives).
The code has been checked in to the Rails Engines repository here:
http://svn.rails-engines.org/test/engines/rails_2.0/
(This is a complete Rails app in order to get testing going.)
Currently there are two tests failing:
Arbitrary code mixing: the test on line 34 in
http://dev.rails-engines.org/repository/file/test/engines/rails_2.0/test/unit/arbitrary_code_mixing_test.rb
Model/Lib loading precedence:
http://dev.rails-engines.org/repository/file/test/engines/rails_2.0/test/unit/model_and_lib_test.rb
(ignore the note about functional/view_loading_test.rb in there)
Also, the ActionMailer seems to have changed in Rails 2.0 and this
part of Engines is currently just deactivated.
That said, all the other tests are passing, i.e. the basic
functionality (like model/view/controller loading, routes, migrations
etc.) already seems to work. (I also have it being used at a client of
mine for test purposes and there haven't been any problems with the
basic stuff.)
If you want to get involved with helping here, ... I guess that's
appreciated as everybody seems to be pretty busy these days.
Am 07.12.2007 um 20:29 schrieb Tony Arcieri:
Hi,
Did you get anywhere with this? I'd be interested in helping out
assembling an Engines plugin for 2.0
On Nov 25, 2007 4:06 PM, Sven Fuchs <[EMAIL PROTECTED] >
wrote:
Hi James,
I've now managed to look through the codebase.
Basically I'd like to start refactoring from my patch and successively
remove duplicate functionality.
I'm not sure if it makes sense to partition this up (you asked for
investigations as to which parts of the codebase I'd want to touch).
As far as I can see there's:
- the Engines' plugin class could probably be replaced by a module
that would be mixed into the Rails::Plugin class
- some of the Engine module could probably moved to
Rails::Plugin::Loader or to a Engine::PluginLoader that extends from
the latter
- a dedicated Engine::PluginLocator might be superflous then because
the Rails::Plugin class would be used and Rails::Plugin::Loader seems
to keep track of the plugin instances (is it accessible though?)
- Engines::RailsExtensions::RailsInitializer could be removed (it
already is in my patch)
These might be fine as they are:
Engines::PluginMigrator
Engines::RailsExtensions::ActiveRecord
Engines::RailsExtensions::Dependencies
Engines::RailsExtensions::Migrations
Engines::RailsExtensions::PublicAssetHelpers
Engines::RailsExtensions::Templates
I've also looked for test suites in the repository. There seem to be
several applications for testing different Rails versions. The "rails
edge" application doesn't seem to have any engines installed, the
tests seem to rely on them though ("alpha_engine" etc.). Am I missing
something obvious?
--
Tony Arcieri
ClickCaster, Inc.
[EMAIL PROTECTED] _______________________________________________
Engine-Users mailing list
[EMAIL PROTECTED]
http://lists.rails-engines.org/listinfo.cgi/engine-users-rails-engines.org
--
sven fuchs [EMAIL PROTECTED]
artweb design http://www.artweb-design.de
grünberger 65 + 49 (0) 30 - 47 98 69 96 (phone)
d-10245 berlin + 49 (0) 171 - 35 20 38 4 (mobile)
_______________________________________________
Engine-Users mailing list
[EMAIL PROTECTED]
http://lists.rails-engines.org/listinfo.cgi/engine-users-rails-engines.org
_______________________________________________
Engine-Developers mailing list
[email protected]
http://lists.rails-engines.org/listinfo.cgi/engine-developers-rails-engines.org
