Hi,

The collaboa site for engines is having serious problems, so I'm posting here.

As mentioned previously, rake 0.8.x broke the code for redefining rake tasks.

The problem is that in rake 0.8.x, the first argument to resolve_args should 
now be an array.  Also, last_comment was changed to last_description.

So, this will only work with rake 0.8.x.

Any chance to get this patch into engines /branches/rb_1.2?  Not sure what 
should be done about BC on this.  Any ideas?

Thanks,
John

--- engines.rake        2007-12-29 22:54:17.000000000 -0800
+++ engines.rake.new    2007-12-29 22:54:10.000000000 -0800
@@ -6,14 +6,14 @@
   module Rake
     module TaskManager
       def redefine_task(task_class, args, &block)
-        task_name, deps = resolve_args(args)
+        task_name, deps = resolve_args([args])
         task_name = task_class.scope_name(@scope, task_name)
         deps = [deps] unless deps.respond_to?(:to_ary)
         deps = deps.collect {|d| d.to_s }
         task = @tasks[task_name.to_s] = task_class.new(task_name, self)
         task.application = self
-        task.add_comment(@last_comment)
-        @last_comment = nil
+        task.add_description(@last_description)
+        @last_description = nil
         task.enhance(deps, &block)
         task
       end
_______________________________________________
Engine-Developers mailing list
[email protected]
http://lists.rails-engines.org/listinfo.cgi/engine-developers-rails-engines.org

Reply via email to