Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: Failure pop-up is shown after a false success pop-up(#781822) ......................................................................
webadmin: Failure pop-up is shown after a false success pop-up(#781822) https://bugzilla.redhat.com/781822 - Import a VM from import domain. - Try importing the same VM again, which should fail on CanDoAction. - First a (false) success pop-up is shown (with the text "Import process has begun for VM(s)..."). After clicking on close, a CanDoAction failure pop-up is shown (with the text Error... Import VM failed..."). There were two problems: - The success popup was shown in any case (in VmBackupModel), whatever something has been successfully imported or not. Changed to be shown only if at least one VM can be imported (getCanDoAction() returns true). - To find out if the VM can be imported the getSucceeded() was used. As the server returns only the result for the getCanDoAction() and than starts to execute the action (see the MultipleActionsRunner class), the success message always contained no VMs listed. Changed to use the getCanDoAction() method. The new behaviour is now as follows: Let A and B be virtual machines exported to some domain and the import of both is requested, than: - if both can be imported, only the success message will be shown - if both can not be imported, only the error message will be shown - if A can be imported and B can not, than firt a success message for A will be shown, than an error message for B will be shown Change-Id: I8d1640ea180b051edebc5843a09eac2192b35c1b --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 1 file changed, 20 insertions(+), 15 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/1064/1 -- To view, visit http://gerrit.ovirt.org/1064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8d1640ea180b051edebc5843a09eac2192b35c1b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
