Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Clicking on Enable Power Management does nothing (#771893) ......................................................................
webadmin: Clicking on Enable Power Management does nothing (#771893) https://bugzilla.redhat.com/771893 When a host has no Power Management configured, clicking on the Enable Power Management action item does not do anything. It should open the Edit Host dialog on the Power Management tab. This is true for all host statuses. There were two problems: - After logout-login still the old model instance was used in SubTabHostGeneralPresenter. This caused that when clicking on the action button nothing happened. Solved by listening on onCommonModelChange() and re-initializing the alerts. - The check, if the power management tab should be opened or not was done before the data from the server arrived (in HostPopupPresenterWidget.init()). This caused that always the General tab has been shown. The fix was to move this check into a listener, which waits until the relevant data from the server arrives and after than activates the relevant tab. Change-Id: I61c04f2dafb53f3558a4134e31d61b3d80c25032 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java 3 files changed, 32 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61c04f2dafb53f3558a4134e31d61b3d80c25032 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
