Moti Asayag has posted comments on this change. Change subject: engine-core: cleaning up paramter classes ......................................................................
Patch Set 1: (4 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java Line 12: private ImageOperation operation = ImageOperation.forValue(0); enum can be set with an explicit value instead of using the ordinal. Line 14: private VolumeFormat volumeFormat = VolumeFormat.forValue(0); same for this one and the two lines below .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java Line 24: private VdcActionType parentCommand = VdcActionType.forValue(0); this could be change to the the actual value VdcActiontype.Unknown Line 33: private java.util.ArrayList<VdcActionParametersBase> imagesParameters; the java.util can be omitted around the entire file and use the import java.util.ArrayList instead. -- To view, visit http://gerrit.ovirt.org/1113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00bf20516f3356c1b6935ebfa393aa0d3c1eb84a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jonathan Choate <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
