Moti Asayag has posted comments on this change.
Change subject: engine : Code clean up
......................................................................
Patch Set 1: Verified; Looks good to me, approved
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
Line 42: catch (java.lang.Exception e) {
same here
Line 70: } catch (java.lang.Exception e) {
the prefix of java.lang. could be removed as well.
Line 89: log.errorFormat("Command Factory: Failed to create command
{0} using reflection\n. {1}", type, e);
The exception will be used here both for its message and stacktrace.
i'd use the ExceptionUtils.getMessage(e) as argument for {1} as:
log.errorFormat("Command Factory: Failed to create command {0} using
reflection\n. {1}",
type, ExceptionUtils.getMessage(e), e);
--
To view, visit http://gerrit.ovirt.org/1138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I026764ba88e0651126829ec5a46de01d4786a50c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
