Moti Asayag has posted comments on this change.
Change subject: engine-core: clean and fix typos
......................................................................
Patch Set 6: (8 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java
Line 28:
context.buildConstraintViolationWithTemplate("NETWORK_ADDR_MANDATORY_IN_STATIC_IP")
wouldn't it be safer to use
VdcBllMessages.NETWORK_ADDR_MANDATORY_IN_STATIC_IP.name() ?
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
Line 319: NETWORK_ALREADY_ATTACH_TO_CLUSTER,
would you like also to update this one to NETWORK_ALREADY_ATTACHED_TO_CLUSTER ?
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 352: NETWORK_IN_USE=The Logical Network is in use.
please remove tws
Line 391: NETWORK_VLAN_IN_USE=The specified VLAN ID is already in use.
please remove tws
....................................................
File backend/manager/modules/utils/src/test/resources/AppErrors.properties
Line 255: NETWORK_ALREAY_ATTACH_TO_INTERFACE=Network is already attached to an
interface
Shouldn't it be changed to NETWORK_ALREAY_ATTACHED_TO_INTERFACE ?
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 566: String NETWORK_ALREAY_ATTACH_TO_INTERFACE();
Shouldn't it be changed to NETWORK_ALREAY_ATTACHED_TO_INTERFACE ?
....................................................
File
frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 310: NETWORK_ALREAY_ATTACH_TO_INTERFACE=Network is already attached to an
interface
Shouldn't it be changed to NETWORK_ALREAY_ATTACHED_TO_INTERFACE ?
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 334: NETWORK_ALREAY_ATTACH_TO_INTERFACE=Logical Network is already
attached to a Network Interface.
Shouldn't it be changed to NETWORK_ALREAY_ATTACHED_TO_INTERFACE ?
--
To view, visit http://gerrit.ovirt.org/1062
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d516b6b0cdba3232982be0253ad56de4e062c3e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
