Michael Kublin has posted comments on this change. Change subject: engine: Assign quota id for consumable commands ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmOperationParameterBase.java Line 32: Why u assign a default value, it is really needed ? Line 34: I never saw where are using that parameter, but possible will be in next patch. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java Line 19: private Guid quotaId = new Guid(); Same there, why to assign a default value? -- To view, visit http://gerrit.ovirt.org/1336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idef1bc9335c4c63fdc1daa1ce465e68253af7831 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
