Michael Kublin has posted comments on this change. Change subject: core: Take 2: Prepration for query permissions ......................................................................
Patch Set 5: (2 inline comments) Clean up is great .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java Line 211: don't need @XmlElement annotation, it was needed only on older version .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java Line 275: Please write VdcQueryAuthType.Admin.equals(authType) for me it is better, it is usually better to write const.equals(something) -- To view, visit http://gerrit.ovirt.org/1272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccc044e8527a5f901ad13dcb5289fa8c7b87204 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
