Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Rename MergeSnapshot to RemoveSnapshot
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
Line 68: log.error("Cannot remove merge VM snapshot. Vm is not
Down");
"remove merge" is hard to understand
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotParameters.java
Line 12: @XmlType(name = "MergeSnapshotParamenters")
cant we remove this xmlType annotation?
--
To view, visit http://gerrit.ovirt.org/1127
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c139146bcca40a0158fce6eb87a3328b011b098
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
