Jaroslav Henner has posted comments on this change. Change subject: sdk: Add HTTP request and response hooks. ......................................................................
Patch Set 3: (1 inline comment) .................................................... File src/ovirtsdk/infrastructure/proxy.py Line 42: I cannot see anything in the git, except the following. Is that what you mean? src/codegen/main.py: if(DEBUG): print 'adding to collection: ' + collection + ', url: ' + url + ', get() method:\n' + get_method printing to stdout is not so good for us. Also, not having this, we will not be able to modify the outgoing xml so we will loose the chance to discover some bugs in the rhevm. For example there could be some difference in rhevm-api behavior between empty tag and tag completely missing. Also the tags order could be significant... Note that in last two weeks I took an advantage from having this hooks twice and it doesn't harm anything. -- To view, visit http://gerrit.ovirt.org/1649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52562f96039d416e3e728406ddd1b95d4db04ac7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Jaroslav Henner <[email protected]> Gerrit-Reviewer: Jaroslav Henner <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
