Alex Lourie has posted comments on this change. Change subject: packaging: add sequences to engine-setup (plugins step 2/3) ......................................................................
Patch Set 4: (2 inline comments) Please review comments. .................................................... File packaging/fedora/setup/engine_sequences.py Line 110: condFunc = cond[0] Please consider using cond[1:] instead of removing the first element Line 114: Please add a comment here explaining the purpose of (*cond) -- To view, visit http://gerrit.ovirt.org/1643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b2ac6255f47e8e09d0b0e9972858864bcbd7f3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Idan Mansano <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ronen Angluster <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
