Vojtech Szocs has posted comments on this change.

Change subject: userportal: Detail (sub-tab) support for side-tabs
......................................................................


Patch Set 1:

Note: when you select VM side-tab within Extended main tab, initially all VM 
table action buttons will be enabled.

This is because UserPortalListModel.UpdateActionAvailability() is not called 
properly.

There are two solutions for this:

- UiCommon change: call UpdateActionAvailability() within UserPortalListModel 
constructor

- Application change: call UserPortalListModel.setSelectedItem(null) -> 
UserPortalListProvider.setSelectedItems(emptyList)

What do you think guys?

--
To view, visit http://gerrit.ovirt.org/1734
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70b87fa717627905b26704e92c54a1b1e5b56b32
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to