Yair Zaslavsky has posted comments on this change.

Change subject: engine-core: adding ensureDomainMap to ImportVmTemplateCommand
......................................................................


Patch Set 1:

IIRC, You spoke about improving the current storage related design. I think 
that in flows concerning images, there is code that can be shared, but maybe 
not via inheritance.
I think that maybe introducing a new helper /utilities class will be 
appropriate.
However, this is just a suggestion of improvement, just wanted to make myself 
clear, and if you disagree, just mention that, and we'll close the discussion 
and I will give you +2.

--
To view, visit http://gerrit.ovirt.org/1743
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ff7525d1f51abe05905831451e0176e750cf707
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to