Omer Frenkel has posted comments on this change.
Change subject: engine: Remove quota command
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java
Line 26: if (getParameters() == null || (getParameters().getQuotaId()
== null)) {
you have to add a canDoAction message if you fail canDoAction
Line 29: // TODO : Add Check if there are no VMs/images that are part
of the Quota.
dont forget to implement this check
Line 41: return Collections.singletonMap(getStoragePoolId() == null ?
null : getStoragePoolId().getValue(),
also here, i think permission should be required on the quota obj and not on
the pool (and as well, id should match the object type)
--
To view, visit http://gerrit.ovirt.org/1330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia252d597dbed227d8235107f758ef2c8a2de46dd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
