Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: moved the webadmin specific definition to webadmin
......................................................................
webadmin: moved the webadmin specific definition to webadmin
The UiMenuBarButtonDefinition contained this configurations of the
triangle_down image:
@Source("org/ovirt/engine/ui/webadmin/images/triangle_down.gif")
@ImageOptions(width = 7, height = 5)
As this two options are specific to webadmin, they should be defined on
the webadmin layer. The abstract layer should not define the project
specific resources or create (GWT.create) project specific resources.
The practical consequence in this case was a fail of the build, because
the org/ovirt/engine/ui/webadmin/images/triangle_down.gif was not
found in the gwt-common project
Change-Id: If19bc6669e6f42d94c97489a912a8732ea1bb78b
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiMenuBarButtonDefinition.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/WebAdminMenuBarButtonDefinition.java
2 files changed, 25 insertions(+), 17 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1804
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If19bc6669e6f42d94c97489a912a8732ea1bb78b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
