Omer Frenkel has posted comments on this change.
Change subject: engine: Add audit log messages
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 309: mSeverities.put(AuditLogType.USER_DELETE_QUOTA,
AuditLogSeverity.NORMAL);
no severities for failures?
Line 310:
mSeverities.put(AuditLogType.USER_EXCEEDED_QUOTA_VDS_GROUP_GRACE_LIMIT,
AuditLogSeverity.ALERT);
i think alert is only for hosts and has special treatment, please consult with
Eli about this (or add him as a reviewer so we all can learn)
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 82: USER_FAILED_ADD_QUOTA=Failed to complete add Quota ${QuotaName}. The
operation was initiated by ${UserName}.
why does it phrased as an async operation? we usually use:
"Failed to add Quota ${QuotaName} (User: ${UserName})."
same for update and delete
--
To view, visit http://gerrit.ovirt.org/1746
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0a9fba6b4d061ddd0df524517f0d298877f432f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
