Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: Prestarted Vm (3 - Review Only)
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
Line 135: protected static boolean CanAttachPrestartedVmToUser(Guid vmId) {
does this have to be static?
Line 215: private static boolean vmAssignedToUser(Guid vmId,
ArrayList<String> messages) {
same, does this have to be static?
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
Line 78: import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
Why do we need these imports?
--
To view, visit http://gerrit.ovirt.org/1799
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I284772273a12a3accdfacbe98ab898347a92d941
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
