Mike Kolesnik has posted comments on this change.
Change subject: core: DO NOT SUBMIT common: Fixing entities to reflect removal
of DiskImageTemplate
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java
Line 77: return (mapping != 0) ? Integer.toString(mapping) : null;
Why change to this?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageOwnerType.java
Line 10: public enum DiskImageOwnerType {
Shouldn't this be VmType then?
Since that's what it really represents.
In the image the field can be ownerType.
--
To view, visit http://gerrit.ovirt.org/1569
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2a57c9aa221e2da37906b5ca254270db0aea0ae
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
