Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetVmPoolById, GetVmByVmId,
GetVmTemplatesDisks
......................................................................
Patch Set 1: (4 inline comments)
some minor corrections
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageTemplateDAO.java
Line 21: * Retrieves all templates related to the given VM template id
with optional filtering.
Should be without filtering
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java
Line 17: import org.springframework.jdbc.core.simple.SimpleJdbcTemplate;
Is this eclipse's ordering?
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAOHibernateImpl.java
Line 47: throw new NotImplementedException("This method is not
implemented for Hibernate yet");
please use exception from compat package.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAO.java
Line 15: public interface VmPoolDAO extends DAO, SearchDAO<vm_pools> {
why?
--
To view, visit http://gerrit.ovirt.org/1901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97a6c09d972f50ba3f3b8c5057535fa9ffead5df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
