Allon Mureinik has posted comments on this change.

Change subject: core: Permission filtering for GetTemplateInterfacesByTemplateId
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File backend/manager/dbscripts/network_sp.sql
Line 694: Create or replace FUNCTION Getvm_interfaceBytemplate_id(v_template_id 
UUID, v_user_id UUID, v_is_filtered boolean) 
white space - please remove

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAO.java
Line 38:      * @param isFiltered
start the @return tag on a new line please.

--
To view, visit http://gerrit.ovirt.org/1902
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d63141be309be4c2b04cd7973a89961830afd7d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to