Allon Mureinik has posted comments on this change. Change subject: core: Adding string2Map method to StringUtils(ReviewOnly) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StringUtils.java Line 98: */ Consider stripping white spaces before splitting the string to support strings like "myKey = myValue, someOtherKey= someOtherValue". Also, adding a unit test would be nice :-) -- To view, visit http://gerrit.ovirt.org/1971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1373dfb67f18c4b2560f83094dabf0d75011345 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
