Michael Kublin has posted comments on this change. Change subject: core : Fixing broken unit test: RunVmCommandTest ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java Line 659: retValue = false; the code of isEmpty : return size == 0; so performance can not be better. (Two comperisons at isEmpty approach, getSize()> 0 only one) Readable it is personal choose. -- To view, visit http://gerrit.ovirt.org/1964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15e2f3ca3abea0abdc9216869e1fed76899c7f8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
