Yair Zaslavsky has posted comments on this change.
Change subject: core: Added snapshots table & entity
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/03_01_0380_add_snapshots_table.sql
Line 1: CREATE OR REPLACE FUNCTION Upgrade_AddSnapshotsTable_03_01_0110()
Didn't we say we don't need these functions anymore (no re-entrancy of scripts?)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java
Line 226: public enum SnapshotStatus {
Is this going to be exposed for GWT ? I wonder how it handles "inner type"
definitions in its enums.java class? (I understand why you wanted it here, but
I think that we should double check with GWT guys in case we intend to expose
this)
--
To view, visit http://gerrit.ovirt.org/1965
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida42ebfd26608380a50b6dd7a0f497ad0c9dd835
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches