Yair Zaslavsky has posted comments on this change. Change subject: core: Exctract VM network management code ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java Line 675: VmInterfaceManager vmInterfaceManager = new VmInterfaceManager(); About stateless issue - I dont care that the methods stay non static. Why cant yhou have a method like VmInterfaceManager getVmInterfaceManager() which will always return the same instance that is kept as a private static field. I may have missed it, but i do not see any fields in VmInterfaceManager which cancel it completely from being stateless. About the tests- I think that using my proposed way you will be able to do mocks. -- To view, visit http://gerrit.ovirt.org/1969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b718fdb8291f2ec0237ffb54d7803e6233821f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
