Allon Mureinik has posted comments on this change. Change subject: core: Refactoring AbstractQueryTest ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java Line 38: ThereIsNoSuchQuery query = new ThereIsNoSuchQuery(mock(VdcQueryParametersBase.class)); Tried that - no go :-( PowerMock, static mocks and the validator in QueriesCommandBase don't play nice together. Line 85: // get the getQueryType method - note that it's private. Yes. Will remove in next patchset. Line 106: // TODO: Temporarily commented out until permission checking will be re-enabled, comment this back in when possible Agreed - will upload a new patchset. -- To view, visit http://gerrit.ovirt.org/2035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2bcb752744bfaaf5b82272839d843f4078fd567 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
