Mike Kolesnik has posted comments on this change.
Change subject: core: Added filtering option to DiskImageDAO
......................................................................
Patch Set 15: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java
Line 249: assertEquals("VM should have two disks", 0, disks.size());
Text should say "zero disks"
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOWrapperImplTest.java
Line 13: public class DiskImageDAOWrapperImplTest {
I'm not sure this is necessary, currently whole Hibernate code isn't working
anyway, and if it would work it woul need to comply with the existing dao test.
--
To view, visit http://gerrit.ovirt.org/1841
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15aeb5732c8cc56d0a3ab681d36c33473b004560
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
