Maor Lipchuk has posted comments on this change.

Change subject: engine: Add consume quota permission to add Tempalte
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 433:     }
Originally there was no call to the parent command, 

I think maybe its better not to call the parent since in the parent command 
(VmTemplateCommand), we check if there is a permission on the template, since 
the template is not yet exist, I think the operation will fail.

--
To view, visit http://gerrit.ovirt.org/2112
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e0d33989e517876bfec13b9e89e8d0a99ec0424
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to