Moti Asayag has posted comments on this change. Change subject: core: remove parameter duplication in installVdsParameters ......................................................................
Patch Set 1: This patch does more than described on commit message: besides the rightfully parameter adjustment, it also expose the parameter to the Add host command. Therefore I suggest either update the commit message or better to extract AddVdsCommand.java into its own patch + add support for upgrade as well since via UpdateVdsCommand we can run host installation (via re-install option in UI) and the isReboot is meaningful also on that scenario. -- To view, visit http://gerrit.ovirt.org/2180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I093743f7ea05ef1e2a3f6edd3bcd64355b5c7ad5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
