Vojtech Szocs has posted comments on this change. Change subject: gwt: Removal of SharedGwt module ......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve Hi, I've tried to apply the patch and got "patch does not apply" errors, so I manually resolved these errors and submitted new patch. I like the fact that original SharedGwt GWT module is now split into different logical GWT modules (SearchBackend, Common and Compat). Here are some of my notes: - userportal declares provided dependencies on gwt-common and uicommon. gwt-common declares provided dependency on uicommonweb. This might sound we will end up with both uicommon and uicommonweb in userportal. However, since gwt-common is provided, uicommonweb (provided) is not propagated into userportal, so this is OK (no uicommonweb in userportal). - userportal is now built against GWT 2.3.0 (as defined in userportal pom.xml). Maybe we should move 'gwt.version' property to the parent pom.xml? -- To view, visit http://gerrit.ovirt.org/2164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddd8c8d9a64c2b661d81f46dcc95d2f166034250 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Danny Rankevich <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
