Allon Mureinik has posted comments on this change. Change subject: core-db: Added stored procedures for bridgeless networks BL ......................................................................
Patch Set 7: Looks good to me, but someone else must approve (4 inline comments) Looks good. There are several TWS you missed - see inline. .................................................... File backend/manager/dbscripts/network_actions_sp.sql Line 2: RETURNS SETOF BOOLEAN Please remove TWS Line 20: INNER JOIN vds ON nic.vds_id = vds.vds_id I'd add "AND nic.netrok_name IS NOT NULL" .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkActionsDAO.java Line 12: * other interfaces types, must be bridged to be able to run virtual vm_interface on top of it. Please remove TWS .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java Line 67: */ Optional: I'd use new Guid(String), just in order to follow convention in this class. -- To view, visit http://gerrit.ovirt.org/2317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I820ac8d1c161e53f4b79c8d70cca4c4c66df2de9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
