Einav Cohen has posted comments on this change. Change subject: core: User Configuration Values ......................................................................
Patch Set 3: (5 inline comments) some comments embedded. Please take a look. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java Line 30: SpiceUsbAutoShare, SpiceUsbAutoShare should actually be available for users; The fact that it is currently not being used in the user portal is a bug. Line 32: ImportDefaultPath(ConfigAuthType.User), I think that ExportDefaultPath and ImportDefaultPath are obsolete. But even if they aren't, they represent directory paths on Host/storage-domain that shouldn't be exposed to the user. Line 38: HighUtilizationForPowerSave(ConfigAuthType.User), All configuration values regarding selection-algorithm/load balancing (i.e. VdsSelectionAlgorithm, LowUtilizationForEvenlyDistribute, LowUtilizationForPowerSave, HighUtilizationForPowerSave) should either be exposed to the user or not. I suggest to not expose them to the user - they are irrelevant to him. Line 43: VdsFenceType(ConfigAuthType.User), Since user isn't supposed to deal with Host Power Management options, I suggest to not expose this configuration value to the user. Line 64: SupportCustomProperties(ConfigAuthType.User), All Custom Properties related configuration values should be either exposed or not. I suggest to expose them all (i.e., expose UserDefinedVMProperties and PredefinedVMProperties to users) -- To view, visit http://gerrit.ovirt.org/2394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I347c4d3fc540494bbd4db4896bd1ad718157b3ec Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
