Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT] core: Migrate snapshots data & start using table
......................................................................
Patch Set 5: (5 inline comments)
h
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 124: } else {
not sure i understand what is going on here (even after reading your answer to
muli on previous patch)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
Line 136:
image.setvm_snapshot_id(DbFacade.getInstance().getSnapshotDao().getId((Guid)
getParameters().getEntityId(), SnapshotType.ACTIVE));
is this valid for all the cases create snapshot is called (like
TryBackToSnapshotCommand)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
Line 88: "Active VM before the preview",
maybe "Active VM snapshot before the preview"?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 202: vm.setstatus(VMStatus.Down);
why did you make this change?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1232:
vmNewDynamicData.setapp_list(vmToUpdate.argvalue.getapp_list());
this should be set for the snapshot, no?
--
To view, visit http://gerrit.ovirt.org/2314
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fa10e27736b05cf95fac22d088156b83de0747c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
