Allon Mureinik has posted comments on this change.
Change subject: core: Add query to retrieve Snapshots of VM
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
Looks good, basically, see some minor issues inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmSnapshotsByVmIdQuery.java
Line 9: /**
I think you mean "snapshots", not "queries"
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsByVmIdParameters.java
Line 19: public RegisterableQueryReturnDataType
GetReturnedDataTypeByVdcQueryType(VdcQueryType queryType) {
something seems odd with the indendation of this {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
Line 74: @Deprecated
If you're deprecating the query type, consider deprecating the actual query and
its parameters too.
--
To view, visit http://gerrit.ovirt.org/2600
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2937c45a01047f494bde20834fc24bd6c2daf4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
