Maor Lipchuk has posted comments on this change. Change subject: engine: Add basic search for disks ......................................................................
Patch Set 3: (3 inline comments) .................................................... File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskImageConditionFieldAutoCompleter.java Line 88: java.util.Date tmp = new java.util.Date(java.util.Date.parse(StringHelper.trim(value.argvalue, '\''))); true, will change Line 95: protected Log log = LogFactory.getLog(getClass()); agreed. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java Line 2810: } +1, sounds great idea. It is actualy a frontend file, I think its better to do it as part of other patch scope. I added the disk image here since without it, the Disk auto complition can not be seen -- To view, visit http://gerrit.ovirt.org/2534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If445baab345c284884523702fd4585f7378d587e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
