Allon Mureinik has posted comments on this change. Change subject: core: Filtering for GetConfigurationValueQuery ......................................................................
Patch Set 12: (1 inline comment) answered inline comment. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValueQuery.java Line 25: returnValue = Config.<Object> GetValue(value, version); there are two possible branches here - either shouldReturnValue() is true, and then reutrnValue would get an actual value, or shouldReturnValue() is false and then reutrnValue is null. It seemed more elegant to me to have two different assignments to returnValue and only one call to getQueryReturnValue().setReturnValue(returnValue), but I can go the other way too. Should I change it? -- To view, visit http://gerrit.ovirt.org/2395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79a442551e826d775224275ce5fe001a0ef98dcf Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
