Allon Mureinik has posted comments on this change.
Change subject: engine-core: minor cleanup in SearchQuery
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
One inline comment about the @SuppressWarnings("null") issue, otherwise looks
good.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
Line 264: if (isExistsValue) {
data can't be null if isExistsValue is true, but not all IDEs are smart enough
to recognize this.
(Specifically, Eclipse Indigo which I'm using shows a (wrong!) warning about it.
--
To view, visit http://gerrit.ovirt.org/2650
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib27391b342f68e3af83d17f84715afa8f3e316d3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
